<div class="gmail_quote">On Fri, Jan 29, 2010 at 1:21 PM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com">blp@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Thu, Jan 28, 2010 at 08:16:36PM -0500, Jesse Gross wrote:<br>
> If an error occured while opening a netdev it would decrement the<br>
> refcount, even though it was never incremented. Depending on<br>
> the timing this could result in either an error message or an<br>
> assertion failure. This workaround simply always increments<br>
> the refcount before openning a device. A more complete fix<br>
> already exists in the netdev overhaul in the 'next' branch.<br>
<br>
</div>Looks good.<br>
<br>
I looked over the code fairly thoroughly after applying this, but I<br>
didn't build or run-time test it.<br>
</blockquote></div><br><div>Thanks, I pushed it to master.</div>