<div class="gmail_quote">On Wed, Apr 14, 2010 at 2:17 PM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com">blp@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Tue, Apr 13, 2010 at 10:41:16AM -0400, Jesse Gross wrote:<br>
> Allow netdev providers to set get_ifindex and get_features it<br>
> null if they would always return EOPNOTSUPP. This is particuarly<br>
> useful for virtual devices.<br>
<br>
</div>Looks fine, but the formatting here looks extra awkward to me:<br>
<div class="im"><br>
> @@ -661,8 +675,9 @@ netdev_get_features(struct netdev *netdev,<br>
> peer = &dummy[3];<br>
> }<br>
><br>
> - error = netdev_get_dev(netdev)->netdev_class->get_features(netdev, current,<br>
> - advertised, supported, peer);<br>
> + get_features = netdev_get_dev(netdev)->netdev_class->get_features;<br>
> + error = get_features ?get_features(netdev, current, advertised, supported,<br>
> + peer) : EOPNOTSUPP;<br></div></blockquote><div><br></div><div>Yeah, that's pretty bad. Fixed. </div></div>