<div class="gmail_quote">On Wed, Apr 21, 2010 at 12:40 PM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com">blp@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Wed, Apr 21, 2010 at 12:37:20PM -0400, Jesse Gross wrote:<br>
> On Wed, Apr 21, 2010 at 12:16 PM, Ben Pfaff <<a href="mailto:blp@nicira.com">blp@nicira.com</a>> wrote:<br>
><br>
> > On Tue, Apr 20, 2010 at 05:22:01PM -0400, Jesse Gross wrote:<br>
> > > The translation of fragmentation-needed messages from outside the<br>
> > > tunnel to inside didn't quite make the transition from the old<br>
> > > GRE implementation to the new one intact. This fixes a number of<br>
> > > minor bugs in the implmentation. The primary issues are with computing<br>
> > > the tunnel header length and comparing the input vs. output values<br>
> > > for tunnel parameters such as the key.<br>
> ><br>
> > How thoroughly do you recommend that I should review this? I looked it<br>
> > over fairly quickly and didn't see anything that looked bad, but I could<br>
> > spend some more time on it, if you think I should, and increase my<br>
> > understanding.<br>
> ><br>
> More than anything this is just a cleanup patch. I tested this<br>
> functionality before I pushed the big changeset, saw that it was broken but<br>
> didn't have disastrous consequences and decided to wait. None of the logic<br>
> here is new - it's all brought over from my path MTU implementation for<br>
> Linux GRE devices. I believe all the PMTUD stuff works now with this patch<br>
> so hopefully there won't be too much more in this area.<br>
><br>
> Obviously you are welcome to review it if you want but if you don't see<br>
> anything obviously stupid it's probably unnecessary.<br>
<br>
</div>I'm happy with what I already saw, then.<br></blockquote><div><br></div><div>Thanks, I pushed it out. </div></div><br>