Hey Ethan,<br><br>Thanks for the review. <br>I will make these changes before pushing the patches. <br><br>thanx!<br>mehak<br><br><div class="gmail_quote">On Sat, Oct 20, 2012 at 10:49 AM, Ethan Jackson <span dir="ltr"><<a href="mailto:ethan@nicira.com" target="_blank">ethan@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> - if (f->nw_proto == IPPROTO_ICMP) {<br>
> + if (f->dl_type == htons(ETH_TYPE_IP) &&<br>
> + f->nw_proto == IPPROTO_ICMP) {<br>
> format_be16_masked(s, "icmp_type", f->tp_src, wc->masks.tp_src);<br>
> format_be16_masked(s, "icmp_code", f->tp_dst, wc->masks.tp_dst);<br>
> - } else if (f->nw_proto == IPPROTO_ICMPV6) {<br>
> + } else if (f->dl_type == htons(ETH_TYPE_IPV6) &&<br>
> + f->nw_proto == IPPROTO_ICMPV6) {<br>
<br>
</div>Traditionally we've put the && on the next line so you end up with:<br>
<div class="im"><br>
> + if (f->dl_type == htons(ETH_TYPE_IP)<br>
</div>> + && f->nw_proto == IPPROTO_ICMP) {<br>
<br>
Otherwise looks good, thanks.<br>
<br>
Acked-by: Ethan Jackson <<a href="mailto:ethan@nicira.com">ethan@nicira.com</a>><br>
</blockquote></div><br>