Thanks for the comments, I've folded them in.<br><br><div class="gmail_quote">On Thu, Dec 27, 2012 at 11:34 AM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com" target="_blank">blp@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, Dec 26, 2012 at 05:16:42PM -0800, Ethan Jackson wrote:<br>
> Theoretically, it's possible for netdev_get_status() to be called<br>
> on a netdev-vport which hasn't had it's configuration set yet. In<br>
<br>
</div>s/it's/its/<br>
<div class="im"><br>
> this case, netdev-vport would dereference a null pointer. This<br>
> problem was found by Jesse Gross <<a href="mailto:jesse@nicira.com">jesse@nicira.com</a>> in review.<br>
<br>
</div>I usually would write this as:<br>
Reported-by: Jesse Gross <<a href="mailto:jesse@nicira.com">jesse@nicira.com</a>><br>
<div class="im"><br>
> Signed-off-by: Ethan Jackson <<a href="mailto:ethan@nicira.com">ethan@nicira.com</a>><br>
> ---<br>
> lib/netdev-vport.c | 6 ++++++<br>
> 1 file changed, 6 insertions(+)<br>
><br>
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c<br>
> index e50103b..9bb5d36 100644<br>
> --- a/lib/netdev-vport.c<br>
> +++ b/lib/netdev-vport.c<br>
> @@ -460,6 +460,12 @@ netdev_vport_get_tnl_iface(const struct netdev *netdev)<br>
> static char name[IFNAMSIZ];<br>
><br>
> ndv = netdev_dev_vport_cast(netdev_get_dev(netdev));<br>
> + if (!ndv->options) {<br>
> + /* Race condition when 'ndv' was created, but did not have it's<br>
<br>
</div>s/it's/its/<br>
<div class="HOEnZb"><div class="h5"><br>
> + * configuration set yet. */<br>
> + return NULL;<br>
> + }<br>
> +<br>
</div></div></blockquote></div><br>