<div>Out of curiosity, did you consider the name xassert() as an alternative to ovs_assert()? It has the advantage of following our established convention.</div><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ static int reentry;<br>
</blockquote><div><br></div><div>I'm not sure if the C spec strictly requires it, but I would feel more comfortable if we initialized this to 0 explicitly.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
+ switch (reentry++) {<br>
+ case 0:<br>
+ VLOG_ABORT("%s: assertion %s failed in %s()",<br>
+ where, condition, function);<br>
+ /* not reached */<br>
</blockquote><div>Minor style bit I may go ahead and make this an abort() for clarity. I.E.</div><div> ovs_abort(); /* not reached */</div><div><br></div><div>Acked-by: Ethan Jackson <<a href="mailto:ethan@nicira.com">ethan@nicira.com</a>><br>
</div><div><br></div><div> </div></div><br>