<div dir="ltr">As requested off list, I've filled out the commit message a bit. I'll merge soon.<div><br></div><div><div> in-band: Use "internal" netdev type for local ports.</div><div> </div><div>
A bridge's local port always has type "internal", so opening it</div><div> with type "system" can't be correct. This was causing upgrade</div><div> problems. Specifically, in certain bridge topologies, if there was</div>
<div> a manager set force-reload-kmod would fail. This is because the</div><div> local port netdev would open in the in-band code with type</div><div> "system", confusing the more important netdev_open() in</div>
<div> iface_create().</div><div> </div><div> Bug #15067.</div><div> Signed-off-by: Ethan Jackson <<a href="mailto:ethan@nicira.com">ethan@nicira.com</a>></div></div></div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Fri, Feb 22, 2013 at 6:53 AM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com" target="_blank">blp@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<p dir="ltr">Looks good, thank you.</p>
<div class="gmail_quote"><div class="im">On Feb 21, 2013 9:18 PM, "Ethan Jackson" <<a href="mailto:ethan@nicira.com" target="_blank">ethan@nicira.com</a>> wrote:<br type="attribution"></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">
A bridge's local port always has type "internal", so opening it<br>
with type "system" can't be correct. This was causing problems<br>
with force-reload-kmod in some circumstances.<br>
<br>
Bug #15067.<br>
Signed-off-by: Ethan Jackson <<a href="mailto:ethan@nicira.com" target="_blank">ethan@nicira.com</a>><br>
---<br>
ofproto/in-band.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/ofproto/in-band.c b/ofproto/in-band.c<br>
index 3b98005..1a08fcc 100644<br>
--- a/ofproto/in-band.c<br>
+++ b/ofproto/in-band.c<br>
@@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char *local_name,<br>
int error;<br>
<br>
*in_bandp = NULL;<br>
- error = netdev_open(local_name, "system", &local_netdev);<br>
+ error = netdev_open(local_name, "internal", &local_netdev);<br>
if (error) {<br>
VLOG_ERR("failed to initialize in-band control: cannot open "<br>
"datapath local port %s (%s)", local_name, strerror(error));<br>
--<br>
1.7.9.5<br>
<br></div></div><div class="im">
_______________________________________________<br>
dev mailing list<br>
<a href="mailto:dev@openvswitch.org" target="_blank">dev@openvswitch.org</a><br>
<a href="http://openvswitch.org/mailman/listinfo/dev" target="_blank">http://openvswitch.org/mailman/listinfo/dev</a><br>
</div></blockquote></div>
</blockquote></div><br></div>