<div dir="ltr">Thanks for this useful tip!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 4, 2013 at 11:01 AM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com" target="_blank">blp@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Jun 04, 2013 at 10:35:03AM -0700, Alex Wang wrote:<br>
> On Tue, Jun 4, 2013 at 10:17 AM, Ben Pfaff <<a href="mailto:blp@nicira.com">blp@nicira.com</a>> wrote:<br>
</div><div class="im">> > Second, iface_configure_qos() tests ->ofp_port for >= 0, which no<br>
> > longer makes sense. I guess it should test for ->ofp_port !=<br>
> > OFPP_NONE now.<br>
> ><br>
><br>
> Thanks for finding this out. This is what I'm most afraid of, in doing such<br>
> change. Just wish I can catch them all. ;D<br>
<br>
</div>I usually find this kind of issue by commenting out the declaration of<br>
the struct member and recompiling. Then the compiler complains each<br>
time the struct member is mentioned in the source code, so you can<br>
easily examine each instance. That is how I found this problem in<br>
review.<br>
<br>
Thanks,<br>
<br>
Ben.<br>
</blockquote></div><br></div>