<div dir="ltr">How about the following change? I choose not to use the term "mega flow" here to avoid confusing outside people. <br><div><br>diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h<br>
index 6e71b4c..203c7eb 100644<br>--- a/include/linux/openvswitch.h<br>+++ b/include/linux/openvswitch.h<br>@@ -410,9 +410,11 @@ struct ovs_key_nd {<br> * @OVS_FLOW_ATTR_CLEAR: If present in a %OVS_FLOW_CMD_SET request, clears the<br>
* last-used time, accumulated TCP flags, and statistics for this flow.<br> * Otherwise ignored in requests. Never present in notifications.<br>- * @OVS_FLOW_ATTR_MASK: Optional Nested %OVS_KEY_ATTR_* attributes specifying<br>
- * the mega flow mask. OVS_KEY_ATTR_* attributes specified only in OVS_FLOW_ATT<br>- * but not here will be treated as wildcard field.<br>+ * @OVS_FLOW_ATTR_MASK: Nested %OVS_KEY_ATTR_* attributes specifying the<br>+ * mask bits for wildcarded flow match. Mask bit value '1' specifies exact<br>
+ * match with corresponding flow key bit, while mask bit value '0' specifies<br>+ * a wildcarded match. Omitting attribute is treated as wildcarding<br>+ * all corresponding fields. Optional for all requests.<br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jun 6, 2013 at 10:46 AM, Jesse Gross <span dir="ltr"><<a href="mailto:jesse@nicira.com" target="_blank">jesse@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou <<a href="mailto:azhou@nicira.com">azhou@nicira.com</a>> wrote:<br>
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h<br>
> index e890fd8..6e71b4c 100644<br>
> --- a/include/linux/openvswitch.h<br>
> +++ b/include/linux/openvswitch.h<br>
> @@ -410,6 +410,9 @@ struct ovs_key_nd {<br>
> * @OVS_FLOW_ATTR_CLEAR: If present in a %OVS_FLOW_CMD_SET request, clears the<br>
> * last-used time, accumulated TCP flags, and statistics for this flow.<br>
> * Otherwise ignored in requests. Never present in notifications.<br>
> + * @OVS_FLOW_ATTR_MASK: Optional Nested %OVS_KEY_ATTR_* attributes specifying<br>
> + * the mega flow mask. OVS_KEY_ATTR_* attributes specified only in OVS_FLOW_ATTR_KEY<br>
> + * but not here will be treated as wildcard field.<br>
<br>
</div>Can you expand this comment a little bit? Outside of people that have<br>
been working on it, I'm not sure that the term mega flow is really<br>
self-descriptive.<br>
</blockquote></div><br></div>