<div dir="ltr">Thanks for the reply,<div><br></div><div>My review of 06/07 patches is done.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 24, 2013 at 10:57 AM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com" target="_blank">blp@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Fri, Jun 21, 2013 at 12:33:29PM -0700, Alex Wang wrote:<br>
> Looks good to me, just found two places where the line length exceeds 79,<br>
<br>
</div>Thanks. I fixed the one in our code and left the other one in sflow<br>
code alone (the line was already too long there and I don't like to<br>
mess with the sflow library).<br>
<div class="im"><br>
> Also, want to ask does it make sense the add line length check during<br>
> 'make'?<br>
><br>
> e.g. the check can be as simple as:<br>
><br>
> grep '.\{80\}' file<br>
<br>
</div>So far, the rules that we check at make time are safety rules, not<br>
style rules. I prefer to enforce style rules socially rather than<br>
mechanically. (And occasionally wider code is more readable than<br>
narrower code.)<br>
</blockquote></div><br></div>