<br><br><div class="gmail_quote">On Tue, Jun 25, 2013 at 2:41 PM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com" target="_blank">blp@nicira.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On Tue, Jun 25, 2013 at 02:38:29PM -0700, Gurucharan Shetty wrote:<br>
> On Tue, Jun 25, 2013 at 2:18 PM, Ben Pfaff <<a href="mailto:blp@nicira.com">blp@nicira.com</a>> wrote:<br>
><br>
> > On Tue, Jun 25, 2013 at 01:02:31AM -0700, Gurucharan Shetty wrote:<br>
> > > Currently, if we have just one database, we can optionally skip the<br>
> > > database name when providing the DB path for certain options (ex:<br>
> > > --remote=db:[db,]table,column). But in case we have multiple databases,<br>
> > > it is mandatory.<br>
> > ><br>
> > > With this commit, we make the database name mandatory. This provides<br>
> > > increased flexibility for an upcoming commit that provides the ability<br>
> > > to add and remove databases during run time.<br>
> > ><br>
> > > Feature #14595.<br>
> > > Signed-off-by: Gurucharan Shetty <<a href="mailto:gshetty@nicira.com">gshetty@nicira.com</a>><br>
> ><br>
> > Please mention this change in NEWS also.<br>
> ><br>
> Does this look fine?<br>
><br>
> diff --git a/NEWS b/NEWS<br>
> index aae3378..fadd9dd 100644<br>
> --- a/NEWS<br>
> +++ b/NEWS<br>
> @@ -7,7 +7,9 @@ post-v1.11.0<br>
> - New "check-oftest" Makefile target for running OFTest against Open<br>
> vSwitch. See README-OFTest for details.<br>
> - The flow eviction threshold has been moved to the Open_vSwitch table.<br>
> -<br>
> + - Database names are now mandatory when specifying ovsdb-server options<br>
> + through database paths(ex: Private key option with the database name<br>
> + should look like "--private-key=db:Open_vSwitch,SSL,private_key").<br>
<br>
</div></div>It looks like you deleted a blank line. We try to keep two blank<br>
lines between the notes for different versions.<br></blockquote><div>Okay. I saw a single blank line between v1.11.0 and v1.10.0 and followed the same. I will add the extra line.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Instead of "paths(ex: ", can you write "paths (e.g. "? This is the<br>
style we use other places.<br></blockquote><div>Will do.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
<br>
Ben.<br>
</blockquote></div><br>