<p dir="ltr">The patches as sent don't create any threads. That's future work, for as-yet unposted patches.</p>
<div class="gmail_quote">On Jun 26, 2013 7:24 PM, "jerry" <<a href="mailto:jerry.lilijun@huawei.com">jerry.lilijun@huawei.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for your quickly reply.<br>
<br>
I have downloaded the codes of ovs-reviews-thread in your "reviews" repository and doing some test on new patches.<br>
<br>
In my test, the multithreaded feature doesn't work and there is no change on ovs-vswitchd threads. Some results of executing "ps -ef | grep ovs" as follows:<br>
<br>
linux-kKoZfU:/mnt/sdb/ovs-reviews-threads # ps -ef |grep ovs<br>
root 24039 1 0 09:27 ? 00:00:00 ovsdb-server /usr/local/etc/ovs-vswitchd.conf.db --remote=punix:/usr/local/var/run/openvswitch/db.sock --remote=db:Open_vSwitch,manager_options --pidfile --detach --log-file<br>
root 24042 1 0 09:27 ? 00:00:00 ovs-vswitchd unix:/usr/local/var/run/openvswitch/db.sock --pidfile --detach --log-file<br>
root 24043 24042 0 09:27 ? 00:00:00 ovs-vswitchd: worker process for pid 24042<br>
<br>
Then I tried to found threads in procfs info of ovs-vswitchd process with pid 24042. The result of executing "ls /proc/24042/task/" as follows:<br>
<br>
linux-kKoZfU:/mnt/sdb/llj/ovs-reviews-threads # ls -l /proc/24042/task/<br>
total 0<br>
dr-xr-xr-x 6 root root 0 Jun 27 09:30 24042<br>
<br>
I can't find any place in code where the added function xpthread_create() is called. To make ovs multithreaded, So I expect data structures added in new patches to be used by existing code in the repository.<br>
<br>
Would you like to share some thoughts on that test results?<br>
<br>
Regards,<br>
Jerry<br>
<br>
On 2013/6/26 23:32, Ben Pfaff wrote:<br>
> On Wed, Jun 26, 2013 at 04:46:38PM +0800, jerry wrote:<br>
>> I noticed that you have sent out 01~09 of 11 patches on files named<br>
>> ovs-thread.c and ovs-thread.h.<br>
><br>
> I sent all of them.<br>
><br>
>> But I can't find the last two patch of them.<br>
><br>
> Look in patchwork or in my "reviews" repository:<br>
> <a href="https://github.com/blp/ovs-reviews/branches" target="_blank">https://github.com/blp/ovs-reviews/branches</a><br>
><br>
>> Also the defined functions and data structures are not used in latest<br>
>> open vswitch codes from git repository.<br>
><br>
> Why would you expect data structures added in new patches to be used by<br>
> existing code in the repository?<br>
><br>
>> Is your work to make ovs multi-threaded? What's the train of thought<br>
>> on the work? In my guess, maybe you separate the work of ofproto run<br>
>> or run_fast from ovs-vswitchd process and run the work as a single<br>
>> thread. Is that right?<br>
><br>
> That's roughly the idea.<br>
><br>
><br>
<br>
<br>
</blockquote></div>