<div dir="ltr">Applied to master and backported to branch 1.10-2.1~</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Feb 26, 2014 at 12:53 PM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@nicira.com" target="_blank">blp@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks.<br>
<br>
Acked-by: Ben Pfaff <<a href="mailto:blp@nicira.com">blp@nicira.com</a>><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Wed, Feb 26, 2014 at 12:50:55PM -0800, Alex Wang wrote:<br>
> Me too, will push for Joe soon<br>
><br>
><br>
> On Wed, Feb 26, 2014 at 12:42 PM, Ben Pfaff <<a href="mailto:blp@nicira.com">blp@nicira.com</a>> wrote:<br>
><br>
> > I think I'm OK with this version. Does anyone have any objections to it?<br>
> ><br>
> > On Tue, Feb 18, 2014 at 04:01:41PM -0800, Joe Stringer wrote:<br>
> > > I asked Ethan and he suggested that Ben might have a better idea.<br>
> > ><br>
> > > Ben, is this approach fine? I'm not entirely clear on what the<br>
> > relationship<br>
> > > is between netdev types and datapath port types.<br>
> > ><br>
> > ><br>
> > > On 18 February 2014 14:45, Alex Wang <<a href="mailto:alexw@nicira.com">alexw@nicira.com</a>> wrote:<br>
> > ><br>
> > > > Acked-by: Alex Wang <<a href="mailto:alexw@nicira.com">alexw@nicira.com</a>><br>
> > > ><br>
> > > > Ethan,<br>
> > > ><br>
> > > > Could you have a look of this patch? Do you think get_vport_type() is<br>
> > > > the right place?<br>
> > > ><br>
> > > > Thanks,<br>
> > > > Alex Wang,<br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > > On Tue, Feb 18, 2014 at 2:26 PM, Joe Stringer <<a href="mailto:joestringer@nicira.com">joestringer@nicira.com</a><br>
> > >wrote:<br>
> > > ><br>
> > > >> When creating tap ports in dpif-linux, the "tap" type is treated the<br>
> > > >> same as "system", and the type is discarded. When dumping datapath<br>
> > > >> port types, this would cause "tap" type to be reported as a "system"<br>
> > > >> type.<br>
> > > >><br>
> > > >> Each time we see a port of the wrong type in bridge_reconfigure(), we<br>
> > > >> remove it and add a port with the correct configuration. This would<br>
> > > >> always occur for tap ports, causing deletion and re-creation of all<br>
> > tap<br>
> > > >> ports each time the bridge was reconfigured.<br>
> > > >><br>
> > > >> This patch makes dpif-linux use netdev to look up port types if the<br>
> > > >> datapath reports that they are of type OVS_VPORT_TYPE_NETDEV.<br>
> > > >><br>
> > > >> Bug #1196289.<br>
> > > >><br>
> > > >> Reported-by: James Schmidt <<a href="mailto:jschmidt@vmware.com">jschmidt@vmware.com</a>><br>
> > > >> Signed-off-by: Joe Stringer <<a href="mailto:joestringer@nicira.com">joestringer@nicira.com</a>><br>
> > > >> ---<br>
> > > >> v2: Fix the issue in dpif-linux instead of ofproto-dpif.<br>
> > > >> ---<br>
> > > >> lib/dpif-linux.c | 7 +++++--<br>
> > > >> 1 file changed, 5 insertions(+), 2 deletions(-)<br>
> > > >><br>
> > > >> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c<br>
> > > >> index f7f5292..18de118 100644<br>
> > > >> --- a/lib/dpif-linux.c<br>
> > > >> +++ b/lib/dpif-linux.c<br>
> > > >> @@ -439,8 +439,11 @@ get_vport_type(const struct dpif_linux_vport<br>
> > *vport)<br>
> > > >> static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);<br>
> > > >><br>
> > > >> switch (vport->type) {<br>
> > > >> - case OVS_VPORT_TYPE_NETDEV:<br>
> > > >> - return "system";<br>
> > > >> + case OVS_VPORT_TYPE_NETDEV: {<br>
> > > >> + const char *type = netdev_get_type_from_name(vport->name);<br>
> > > >> +<br>
> > > >> + return type ? type : "system";<br>
> > > >> + }<br>
> > > >><br>
> > > >> case OVS_VPORT_TYPE_INTERNAL:<br>
> > > >> return "internal";<br>
> > > >> --<br>
> > > >> 1.7.9.5<br>
> > > >><br>
> > > >> _______________________________________________<br>
> > > >> dev mailing list<br>
> > > >> <a href="mailto:dev@openvswitch.org">dev@openvswitch.org</a><br>
> > > >> <a href="http://openvswitch.org/mailman/listinfo/dev" target="_blank">http://openvswitch.org/mailman/listinfo/dev</a><br>
> > > >><br>
> > > ><br>
> > > ><br>
> ><br>
</div></div></blockquote></div><br></div>