<div dir="ltr">Thx for the review, applied to master, branch-2.2</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 1, 2014 at 7:21 PM, Joe Stringer <span dir="ltr"><<a href="mailto:joestringer@nicira.com" target="_blank">joestringer@nicira.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="">On 30 April 2014 12:46, Alex Wang <span dir="ltr"><<a href="mailto:alexw@nicira.com" target="_blank">alexw@nicira.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+dnl set the stats update interval to 100K ms, the following 'recv' should not be updated.<br>
+AT_CHECK([ovs-vsctl set O . other_config:stats-update-interval=100000])<br>
<div>+for i in `seq 0 50`; do ovs-appctl time/warp 1000; done<br>
+for i in `seq 1 5`; do<br>
+ AT_CHECK([ovs-appctl netdev-dummy/receive p1 'eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x0800),ipv4(src=10.0.0.2,dst=10.0.0.1,proto=1,tos=0,ttl=64,frag=no),icmp(type=8,code=0)'])<br>
+done<br>
+<br>
</div>+dnl advance the clock by 100K ms, the previous 'recv' should be updated.<br>
+for i in `seq 0 100`; do ovs-appctl time/warp 1000; done<br>
<div>+OVS_VSCTL_CHECK_RX_PKT([p1], [6])<br></div></blockquote><div><br></div></div><div>Does there need to be an OVS_VSCTL_CHECK_RX_PKT() command in between these two snippets? I don't see a check to show that it's not updated during the time 5000ms -> 100000ms after the setting changed. (only a check to make sure it is updated after 100000ms).</div>
<div class="">
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
+ <column name="other_config" key="stats-update-interval"<br>
</div>+ type='{"type": "integer", "minInteger": 5000}'><br>
<div>+ <p><br>
+ Period of statistics update to database, in milliseconds. </div></blockquote><div><br></div></div><div>Perhaps a bit more natural to say "Interval for updating statistics to the database, in milliseconds".</div>
<div class="">
<div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
+ Key-value pairs that report port statistics. The update period<br>
+ is controlled by <ref column="other_config"<br>
+ key="stats-update-interval"/> of <code>Open_vSwitch</code> table.<br></div></blockquote><div><br></div></div><div>"of" -> "in the". (Also for interface and mirror)</div>
<div><br></div><div><br></div><div>Otherwise, looks good to me.</div><div><br></div><div>Acked-by: Joe Stringer <<a href="mailto:joestringer@nicira.com" target="_blank">joestringer@nicira.com</a>></div></div><br></div>
</div>
</blockquote></div><br></div>