<div dir="ltr">Hi,<br><br>I have recently finished implementing database command ranges according to the suggestion in this thread.<br><br>If you could kindly take a look and give me some input.<br>The summary of the patch is: ovsdb-data: Add support for integer ranges in database commands<div><a href="https://patchwork.ozlabs.org/patch/702873/">patch</a><br><div><br></div><div>I'll try to find myself something else to work on. If you have any suggestions, then please let me know. </div><div><br></div><div>Best regards,</div><div>Lukasz Rzasik</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-10-06 22:07 GMT+02:00 Ben Pfaff <span dir="ltr"><<a href="mailto:blp@ovn.org" target="_blank">blp@ovn.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds good.<br>
<br>
You should read CONTRIBUTING.md and CodingStyle.md.<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Oct 06, 2016 at 09:48:06PM +0200, Łukasz Rząsik wrote:<br>
> Hi,<br>
><br>
> I wanted to start contributing to the project.<br>
> If no one else is already working on that, I will try to implement it and<br>
> submit a patch as a start.<br>
><br>
> BR,<br>
> Lucas<br>
><br>
> 2016-10-04 3:19 GMT+02:00 Ben Pfaff <<a href="mailto:blp@ovn.org">blp@ovn.org</a>>:<br>
><br>
> > This can occupy a lot of space.<br>
> ><br>
> > If you want to support ranges, you can submit a patch.<br>
> ><br>
> > On Mon, Oct 03, 2016 at 10:29:53PM +0000, <a href="mailto:my_ovs_discuss@yahoo.com">my_ovs_discuss@yahoo.com</a> wrote:<br>
> > > Thanks Ben for the response.<br>
> > > I see that whenever an ovs-vsctl command is issued it seems to go into<br>
> > conf.db in JSON format as follows.<br>
> > > ------------------------------<wbr>------------------------------<br>
> > ------------------------------<wbr>------------------------------<br>
> > ------------------------------<wbr>------------------------------<wbr>-------<br>
> > ><br>
> > > OVSDB JSON 350 adea54d6f5617de72668fbac82f4ba<wbr>47f5aa9459<br>
> > > {"_date":1475533349806,"Port":<wbr>{"a2a185d4-c018-481c-9c41-<br>
> > a96998df77b7":{"trunks":["set"<wbr>,[2,3,4,5,6,7,8,9,10,11,12,13,<br>
> > 14,15,16,17,18,19,20,21,22,23,<wbr>24,25,26,27,28,29,30,31,32,33,<br>
> > 34,35,36,37,38,39,4094]]}},"_<wbr>comment":"ovs-vsctl<br>
> > > : /bin/ovs-vsctl add port 123456789012345 trunks<br>
> > 39","Open_vSwitch":{"a0d40d36-<wbr>fae6-4862-90cf-586bded25ae3":{<br>
> > "next_cfg":63}}}<br>
> > > OVSDB JSON 95 c2c2528b873474056ff64640cf5186<wbr>a9ba1dbadb<br>
> > > {"_date":1475533349814,"Open_<wbr>vSwitch":{"a0d40d36-fae6-4862-<br>
> > 90cf-586bded25ae3":{"cur_cfg":<wbr>63}}}<br>
> > > OVSDB JSON 353 ccbb33817b428a65406d93070f3dc3<wbr>c85f5181b5<br>
> > > {"_date":1475533349837,"Port":<wbr>{"a2a185d4-c018-481c-9c41-<br>
> > a96998df77b7":{"trunks":["set"<wbr>,[2,3,4,5,6,7,8,9,10,11,12,13,<br>
> > 14,15,16,17,18,19,20,21,22,23,<wbr>24,25,26,27,28,29,30,31,32,33,<br>
> > 34,35,36,37,38,39,40,4094]]}},<wbr>"_comment":"ovs-vs<br>
> > > ctl: /bin/ovs-vsctl add port 123456789012345 trunks<br>
> > 40","Open_vSwitch":{"a0d40d36-<wbr>fae6-4862-90cf-586bded25ae3":{<br>
> > "next_cfg":64}}}<br>
> > > OVSDB JSON 95 642d4c5ea430d66ca1ce4bd18747cb<wbr>06d2f9227b<br>
> > > {"_date":1475533349845,"Open_<wbr>vSwitch":{"a0d40d36-fae6-4862-<br>
> > 90cf-586bded25ae3":{"cur_cfg":<wbr>64}}}<br>
> > > OVSDB JSON 356 72c1435d0ce4e8393aa0a95da6238c<wbr>a81b78142c<br>
> > > {"_date":1475533349889,"Port":<wbr>{"a2a185d4-c018-481c-9c41-<br>
> > a96998df77b7":{"trunks":["set"<wbr>,[2,3,4,5,6,7,8,9,10,11,12,13,<br>
> > 14,15,16,17,18,19,20,21,22,23,<wbr>24,25,26,27,28,29,30,31,32,33,<br>
> > 34,35,36,37,38,39,40,41,4094]]<wbr>}},"_comment":"ovs<br>
> > > -vsctl: /bin/ovs-vsctl add port 123456789012345 trunks<br>
> > 41","Open_vSwitch":{"a0d40d36-<wbr>fae6-4862-90cf-586bded25ae3":{<br>
> > "next_cfg":65}}}<br>
> > > OVSDB JSON 95 618d1e741f0fbf7e373afb6245b7f2<wbr>a882123d56<br>
> > > {"_date":1475533349897,"Open_<wbr>vSwitch":{"a0d40d36-fae6-4862-<br>
> > 90cf-586bded25ae3":{"cur_cfg":<wbr>65}}}<br>
> > > OVSDB JSON 359 c05800747de4d9e5a9559ac2230e94<wbr>826106f27f<br>
> > > {"_date":1475533349924,"Port":<wbr>{"a2a185d4-c018-481c-9c41-<br>
> > a96998df77b7":{"trunks":["set"<wbr>,[2,3,4,5,6,7,8,9,10,11,12,13,<br>
> > 14,15,16,17,18,19,20,21,22,23,<wbr>24,25,26,27,28,29,30,31,32,33,<br>
> > 34,35,36,37,38,39,40,41,42,<wbr>4094]]}},"_comment":"<br>
> > > ovs-vsctl: /bin/ovs-vsctl add port 123456789012345 trunks<br>
> > 42","Open_vSwitch":{"a0d40d36-<wbr>fae6-4862-90cf-586bded25ae3":{<br>
> > "next_cfg":66}}}<br>
> > > OVSDB JSON 95 e501f33c436fdc44cbb73c5bf40d85<wbr>27473b7895<br>
> > > {"_date":1475533349945,"Open_<wbr>vSwitch":{"a0d40d36-fae6-4862-<br>
> > 90cf-586bded25ae3":{"cur_cfg":<wbr>66}}}<br>
> > > ------------------------------<wbr>------------------------------<br>
> > ------------------------------<wbr>------------------------------<br>
> > ------------------------------<wbr>-------<br>
> > > For each trunk we add, this whole text is getting appended into conf.db<br>
> > and this is per port. This seems to occupy lot of space onfile system.<br>
> > > Is there a way to avoid this and keep only one instance of the config?<br>
> > > -Thanks<br>
> > ><br>
> > ><br>
> > > Sent from Yahoo Mail. Get the app<br>
> > ><br>
> > > From: Ben Pfaff <<a href="mailto:blp@ovn.org">blp@ovn.org</a>><br>
> > > To: <a href="mailto:my_ovs_discuss@yahoo.com">my_ovs_discuss@yahoo.com</a><br>
> > > Cc: "<a href="mailto:discuss@openvswitch.org">discuss@openvswitch.org</a>" <<a href="mailto:discuss@openvswitch.org">discuss@openvswitch.org</a>><br>
> > > Sent: Monday, October 3, 2016 2:29 PM<br>
> > > Subject: Re: [ovs-discuss] Specifying range for bridge port trunks<br>
> > ><br>
> > > On Mon, Oct 03, 2016 at 09:23:59PM +0000, <a href="mailto:my_ovs_discuss@yahoo.com">my_ovs_discuss@yahoo.com</a><br>
> > wrote:<br>
> > > > Hi, We are using openvswitch-2.5.0<br>
> > > > Is there a way to specify a range for trunks under bridge port, like<br>
> > > > vsctl add port port1 trunks 100-250<br>
> > > > It could be for add/set.<br>
> > > > In the conf.db, these trunks seem to be getting stored as individual<br>
> > strings like 100,101,102, ... 250 and it seems to expect the command also<br>
> > likevsctl add port port1 trunks 100,101,102,103...150<br>
> > > > If I have to specify such ranges for multiple ports, the conf.db seems<br>
> > to occupy a lot of space and this format also seems little difficult to<br>
> > specify 100s of integers.<br>
> > > > As I am not that familiar with OVS yet, am I missing something? Is<br>
> > there a way to specify ranges and also minimize the conf.db space by<br>
> > storing the ranges?<br>
> > ><br>
> > > OVS doesn't support ranges here. You can submit a patch to add a new<br>
> > > feature, if you like.<br>
> > ><br>
> > ><br>
> > ><br>
> > ______________________________<wbr>_________________<br>
> > discuss mailing list<br>
> > <a href="mailto:discuss@openvswitch.org">discuss@openvswitch.org</a><br>
> > <a href="http://openvswitch.org/mailman/listinfo/discuss" rel="noreferrer" target="_blank">http://openvswitch.org/<wbr>mailman/listinfo/discuss</a><br>
> ><br>
</div></div></blockquote></div><br></div>