<div dir="ltr">Thanks Ben for the review.<div>I have fixed the tests (basically, now ip or ipv6 is added to the flows) and submitted a v2 of the patch.</div><div><br></div><div>Daniel</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 25, 2017 at 7:21 PM, Ben Pfaff <span dir="ltr"><<a href="mailto:blp@ovn.org" target="_blank">blp@ovn.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Oct 25, 2017 at 06:50:29PM +0530, Numan Siddique wrote:<br>
> On Wed, Oct 25, 2017 at 3:09 PM, Daniel Alvarez Sanchez <<a href="mailto:dalvarez@redhat.com">dalvarez@redhat.com</a><br>
> > wrote:<br>
><br>
> ><br>
> ><br>
> > On Tue, Oct 24, 2017 at 11:35 PM, Ben Pfaff <<a href="mailto:blp@ovn.org">blp@ovn.org</a>> wrote:<br>
> ><br>
> >> On Tue, Oct 24, 2017 at 02:27:59PM -0700, Ben Pfaff wrote:<br>
> >> > On Tue, Oct 24, 2017 at 11:07:58PM +0200, Daniel Alvarez Sanchez wrote:<br>
> >> > > Hi guys,<br>
> >> > ><br>
> >> > > Great job Numan!<br>
> >> > > As we discussed over IRC, the patch below may make more sense.<br>
> >> > > It essentially sets the dl_type so that when packet comes from the<br>
> >> > > controller, it matches<br>
> >> > > a valid type and OVS_KEY_ATTR_CT_ORIG_TUPLE_<wbr>IPV4 is not added.<br>
> >> > > Maybe what Numan proposed and this patch could be a good combination<br>
> >> but I<br>
> >> > > think<br>
> >> > > that we definitely need to set the dl_type as it's later checked in<br>
> >> > > pkt_metadata_from_flow()<br>
> >> > > and it'll be zero there otherwise.<br>
> >> > > What do you guys think? I have tried the patch below and the kernel<br>
> >> error<br>
> >> > > is not shown<br>
> >> > > anymore when issuing DHCP requests.<br>
> >> > ><br>
> >> > ><br>
> >> > > diff --git a/lib/flow.c b/lib/flow.c<br>
> >> > > index b2b10aa..62b948f 100644<br>
> >> > > --- a/lib/flow.c<br>
> >> > > +++ b/lib/flow.c<br>
> >> > > @@ -1073,6 +1073,7 @@ flow_get_metadata(const struct flow *flow,<br>
> >> struct<br>
> >> > > match *flow_metadata)<br>
> >> > ><br>
> >> > > if (flow->ct_state != 0) {<br>
> >> > > match_set_ct_state(flow_<wbr>metadata, flow->ct_state);<br>
> >> > > + match_set_dl_type(flow_<wbr>metadata, flow->dl_type);<br>
> >> > > if (is_ct_valid(flow, NULL, NULL) && flow->ct_nw_proto != 0)<br>
> >> {<br>
> >> > > if (flow->dl_type == htons(ETH_TYPE_IP)) {<br>
> >> > > match_set_ct_nw_src(flow_<wbr>metadata, flow->ct_nw_src);<br>
> >> ><br>
> >> > This patch seems reasonable too.<br>
> >> ><br>
> >> > I recommend adding a comment above it to explain what's going on,<br>
> >> > because dl_type is not a metadata field and it's confusing to deal with<br>
> >> > it in a context that's supposed to be all about metadata. I guess the<br>
> >> > comment would essentially say that dl_type is essential to the<br>
> >> > interpretation of the conntrack metadata.<br>
> >><br>
> >> Oh, and for this patch too I'd welcome a formal patch proposal.<br>
> >><br>
> ><br>
> > Done. Thanks a lot Ben.<br>
> > If this get merged, it would be great if we can get it into 2.8 branch and<br>
> > add a new tag (2.8.2).<br>
> ><br>
> > Thanks!!<br>
> ><br>
><br>
> Ben, we have submitted both the patches. The patch from Daniel - (<br>
> <a href="https://patchwork.ozlabs.org/patch/830160/" rel="noreferrer" target="_blank">https://patchwork.ozlabs.org/<wbr>patch/830160/</a>) will fix the issue.<br>
> Not sure if this patch <a href="https://patchwork.ozlabs.org/patch/830132/" rel="noreferrer" target="_blank">https://patchwork.ozlabs.org/<wbr>patch/830132/</a> is<br>
> needed any more.<br>
><br>
> Request to review these patches if possible as RDO is blocked on these<br>
> patches before we can update from OVS 2.7.2 to OVS 2.8(.2)<br>
<br>
</div></div>I've reviewed both. I wasn't able to immediately apply either one, but<br>
they're obviously moving in the right direction, so I'd appreciate<br>
follow-up from both of you so that we can get them in.<br>
</blockquote></div><br></div>