[ovs-build] Passed: openvswitch/ovs#538 (master - 4c75aaa)

Travis CI notifications at travis-ci.org
Thu Jan 8 02:40:07 UTC 2015


Build Update for openvswitch/ovs
-------------------------------------

Build: #538
Status: Passed

Duration: 21 minutes and 54 seconds
Commit: 4c75aaa (master)
Author: Ethan Jackson
Message: dpif-netdev: Fix rare flow add race condition.

Before this patch, dp_netdev_flow_add() inserted newly minted flows in
the "flow_table" cmap before inserting them into the per core "dpcls"
classifier.  Since dpcls_insert() initializes 'flow->cr.mask', there's
a brief window where the flow is accessible from the cmap, but has a
bogus mask value.

In my testing, under rare instances (i.e. once every 20 minutes with a
very specific flow table and traffic pattern), revalidators core dump
when they call dpif_netdev_flow_dump_next(), which accesses this bogus
mask value from dp_netdev_flow_to_dpif_flow().

By inserting into the per core classifier before the cmap, all the
values are guaranteed to be initialized during flow dumps.  With this
patch, I can no longer reproduce the crash.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>

View the changeset: https://github.com/openvswitch/ovs/compare/8ae8176fd0d8...4c75aaabb153

View the full build log and details: https://travis-ci.org/openvswitch/ovs/builds/46270410

--

You can configure recipients for build notifications in your .travis.yml file. See http://docs.travis-ci.com/user/notifications


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.openvswitch.org/pipermail/ovs-build/attachments/20150108/010f3c53/attachment-0002.html>


More information about the build mailing list