[ovs-build] Failed: blp/ovs-reviews#357 (wildcards - 9d3f53b)

Travis CI builds at travis-ci.org
Sat Apr 23 03:59:41 UTC 2016


Build Update for blp/ovs-reviews
-------------------------------------

Build: #357
Status: Failed

Duration: 2 minutes and 12 seconds
Commit: 9d3f53b (wildcards)
Author: Ben Pfaff
Message: ofproto-dpif-xlate: Always generate wildcards.

Until now, the flow translation code has tried to avoid constructing a
set of wildcards during translation in the cases where it can, because
wildcards are large and somewhat expensive.  However, this has problems
that we hadn't previously realized.  Specifically, the generated actions
can depend on the constructed wildcards, to decide which bits of a field
need to be set in a masked set_field action.  This means that in practice
translation needs to always construct the wildcards.

(It might be possible to avoid masked set_field when we're not constructing
wildcards, but this would mean that we'd generate different actions
depending on whether wildcards were being constructed, which seems rather
confusing at best.  Also, the cases in which we don't need wildcards anyway
are fairly obscure, meaning that the benefits of avoiding them in those
cases are minimal and that it's going to be hard to get test coverage.  The
latter is probably why we didn't notice this until now.)

Reported-by: William Tu <u9012063 at gmail.com>
Reported-at: http://openvswitch.org/pipermail/dev/2016-April/069219.html
Signed-off-by: Ben Pfaff <blp at ovn.org>

View the changeset: https://github.com/blp/ovs-reviews/commit/9d3f53bb0fb1

View the full build log and details: https://travis-ci.org/blp/ovs-reviews/builds/125173066

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.openvswitch.org/pipermail/ovs-build/attachments/20160423/24ff373c/attachment-0002.html>


More information about the build mailing list