[ovs-build] Errored: pshelar/ovs#7 (fx-tavis-tnl - 36d8de1)

Travis CI builds at travis-ci.org
Fri May 20 21:25:46 UTC 2016


Build Update for pshelar/ovs
-------------------------------------

Build: #7
Status: Errored

Duration: 40 minutes and 3 seconds
Commit: 36d8de1 (fx-tavis-tnl)
Author: Daniele Di Proietto
Message: dpif-netdev: Initialize packet RSS hash in dpif_netdev_execute().

The datapath code expects the RSS hash to always be initialized.  This
is enforced by checking in emc_processing() that the hash is valid, and
eventually by computing a new one.

Unfortunately, there is another entry point to the datapath,
dpif_netdev_execute().  A packet generated by OVS (BFD frame,
packet-out from controller) doesn't have a valid RSS hash and so is
allowed to enter the datapath with an uninitialized hash value.

This commit recomputes the hash (if not valid) in dpif_netdev_execute().

The only place where we would use an invalid hash is netdev-vport, in
push_udp_header().  This caused an uninitialized memory read, and a
random value to be assigned to the outer tunnel header source port.

Reported-by: William Tu <u9012063 at gmail.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: William Tu <u9012063 at gmail.com>
Acked-by: Ben Pfaff <blp at ovn.org>

View the changeset: https://github.com/pshelar/ovs/compare/e1b0fb09bed5...36d8de17ffe5

View the full build log and details: https://travis-ci.org/pshelar/ovs/builds/131796479

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.openvswitch.org/pipermail/ovs-build/attachments/20160520/3242dbc9/attachment-0002.html>


More information about the build mailing list