[ovs-build] Failed: openvswitch/ovs#5452 (master - 7b997d4)

[Travis CI]

Build Update for openvswitch/ovs
-------------------------------------

Build: #5452
Status: Failed

Duration: 24 minutes and 32 seconds
Commit: 7b997d4 (master)
Author: Mark Michelson
Message: OVN: Don't let peers be set to "<error>" on port bindings.

There are a couple of places in ovn-northd that set the "peer" option on
certain ports to "<error>" in certain cases. In every case where a peer is
looked up on a port binding, the code performs a NULL check in order to
ensure a peer exists. None check for the "<error>" string. They assume that the
presence of a peer string means a peer is defined and all is well.

In the past (OVS 2.6 series), this sometimes led to patch ports being created
in ovs that had names like "patch-ro-to-<error>". This particular problem
resolved itself in OVS 2.7 since such patch ports were no longer automatically
created. However, by naming the peer "<error>" the seeds are still sown for
similar issues to occur.

The solution this patch suggests is to no longer set the "peer" option
on a port binding to "<error>". Instead, if no peer can be set, then we
set no peer. Since other code is already equipped to deal with this,
this poses no problem.

Signed-off-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

View the changeset: https://github.com/openvswitch/ovs/compare/173acc1c5511...7b997d4f3d99

View the full build log and details: https://travis-ci.org/openvswitch/ovs/builds/295972046?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20171101/92aa9dff/attachment-0001.html>