[ovs-build] Still Failing: openvswitch/ovs#5365 (master - d9e75b8)

Travis CI builds at travis-ci.org
Tue Oct 10 16:04:13 UTC 2017


Build Update for openvswitch/ovs
-------------------------------------

Build: #5365
Status: Still Failing

Duration: 58 minutes and 14 seconds
Commit: d9e75b8 (master)
Author: Ben Pfaff
Message: util: Make ovs_assert() always expand so that it should be followed by ;

ovs_assert() is normally invoked like a function call, e.g.:
    ovs_assert(true);
but its expansion was a full statement, so that this ended up expanding to:
    if (!OVS_LIKELY(true)) {                                       \
        ovs_assert_failure(OVS_SOURCE_LOCATOR, __func__, #CONDITION);       \
    };
with both } and ; at the end, which is weird and somewhat risky around 'if'
statements.

This commit fixes the problem, making ovs_assert() expand to an expression.

Reported-by: Greg Rose <gvrose8192 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

View the changeset: https://github.com/openvswitch/ovs/compare/f61d40dec9f6...d9e75b82999d

View the full build log and details: https://travis-ci.org/openvswitch/ovs/builds/286083599?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20171010/ecab5961/attachment.html>


More information about the build mailing list