[ovs-build] Errored: igsilya/ovs#454 (tmp-branch-2.6 - f063ae0)

Travis CI builds at travis-ci.org
Mon Aug 26 20:22:26 UTC 2019


Build Update for igsilya/ovs
-------------------------------------

Build: #454
Status: Errored

Duration: 43 mins and 27 secs
Commit: f063ae0 (tmp-branch-2.6)
Author: Michele Baldessari
Message: Make pid_exists() more robust against empty pid argument

In some of our destructive testing of ovn-dbs inside containers managed
by pacemaker we reached a situation where /var/run/openvswitch had
empty .pid files. The current code does not deal well with them
and pidfile_is_running() returns true in such a case and this confuses
the OCF resource agent.

- Before this change:
Inside a container run:
  killall ovsdb-server
  echo -n '' > /var/run/openvswitch/ovnnb_db.pid
  echo -n '' > /var/run/openvswitch/ovnsb_db.pid

We will observe that the cluster is unable to ever recover because
it believes the ovn processes to be running when they really aren't and
eventually just fails:
 podman container set: ovn-dbs-bundle
   ovn-dbs-bundle-0  (ocf::ovn:ovndb-servers):   Master controller-0
   ovn-dbs-bundle-1  (ocf::ovn:ovndb-servers):   Stopped controller-1
   ovn-dbs-bundle-2  (ocf::ovn:ovndb-servers):   Slave controller-2

Let's make sure pid_exists() returns false when the pid is an empty
string.

- After this change the cluster is able to recover from this state and
correctly start the resource:
 podman container set: ovn-dbs-bundle
   ovn-dbs-bundle-0  (ocf::ovn:ovndb-servers):   Master controller-0
   ovn-dbs-bundle-1  (ocf::ovn:ovndb-servers):   Slave controller-1
   ovn-dbs-bundle-2  (ocf::ovn:ovndb-servers):   Slave controller-2

Fixes: 3028ce2595c8 ("ovs-lib: Allow "status" command to work as non-root.")
Signed-off-by: Michele Baldessari <michele at acksyn.org>
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

View the changeset: https://github.com/igsilya/ovs/compare/343841129a9c...f063ae0282fe

View the full build log and details: https://travis-ci.org/igsilya/ovs/builds/576850742?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the igsilya/ovs repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=17831080&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20190826/9fe5e97b/attachment-0001.html>


More information about the build mailing list