[ovs-build] Errored: dceara/ovn#126 (engine_run_no_sb_txn-v2 - f51eeca)

Travis CI builds at travis-ci.org
Mon Dec 9 08:06:57 UTC 2019


Build Update for dceara/ovn
-------------------------------------

Build: #126
Status: Errored

Duration: 14 mins and 49 secs
Commit: f51eeca (engine_run_no_sb_txn-v2)
Author: Dumitru Ceara
Message: ovn-controller: Run I-P engine even when no SB txn is available.

If the last ovn-controller main loop run started a transaction to the
Southbound DB and the transaction is still in progress, ovn-controller
will not call engine_run(). In case there were changes to the DB,
engine_need_run() would return true which would trigger an immediate
forced recompute in the next processing loop iteration.

However, there are scenarios when updates can be processed incrementally
even if no Southbound DB transaction is available. One example, often
seen in the field, is when the MAC_Binding table is updated. Currently
such an update received while a transaction is still committing would
trigger a forced recompute.

This patch performs only incremental processing when the SB DB txn
is NULL, which means executing change_handler() methods
only, without calling the run() methods of the I-P engine nodes.
Assuming that some change handlers need to update the DB and that
some don't, if the SB DB txn is NULL:
- if the incoming change doesn't trigger a SB DB update (currently true
  for all existing change handlers) then the change handlers might
  complete without aborting if it doesn't trigger a run() of the node.
- if the incoming change tries to perform a SB DB update, the change
  handler will return false (SB DB txn is NULL) triggering the engine
  to call run() and abort computation.

CC: Han Zhou <hzhou at ovn.org>
CC: Numan Siddique <numans at ovn.org>
Signed-off-by: Dumitru Ceara <dceara at redhat.com>

---
v2:
- Address Han's comments:
  - Remove unnecessary poll_immediate_wake() that could trigger a busy
    loop until the transaction is committed.
  - Document the change_handler requirements regarding using the txn
    pointers returned by engine_get_context().
  - Rephrase commit message.
  - Rebase.

View the changeset: https://github.com/dceara/ovn/compare/e34cd53a66da^...f51eeca7e614

View the full build log and details: https://travis-ci.org/dceara/ovn/builds/622531715?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the dceara/ovn repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=25507942&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20191209/e344023b/attachment.html>


More information about the build mailing list