[ovs-build] Fixed: ovn-org/ovn#23 (master - 5309099)

Travis CI builds at travis-ci.org
Thu Nov 28 13:54:55 UTC 2019


Build Update for ovn-org/ovn
-------------------------------------

Build: #23
Status: Fixed

Duration: 18 mins and 59 secs
Commit: 5309099 (master)
Author: Dumitru Ceara
Message: ovn-controller: Consider non-virtual ports first when updating bindings.

There's no guarantee SBREC_PORT_BINDING_TABLE_FOR_EACH will first
return the non-virtual ports and then virtual ports. In the case when a
virtual port is processed before its virtual_parent,
consider_local_datapath might not release it in the current
ovn-controller iteration even though the virtual_parent gets released.

Right now this doesn't trigger any functionality issue because releasing
the virtual_parent triggers a change in the SB DB which will wake up
ovn-controller and trigger a new computation which will also update the
virtual port.

However, this is suboptimal, and we can notice that often ovn-controller
gets the SB update notification before the "transaction successful"
notification. In such cases the incremental engine doesn't run
(ovnsb_idl_txn == NULL) and a full recompute is scheduled for the next
run. By batching the two SB updates in a single transaction we
lower the risk of this situation happening.

CC: Numan Siddique <numans at ovn.org>
Fixes: 054f4c85c413 ("Add a new logical switch port type - 'virtual'")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: Mark Michelson <mmichels at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>

View the changeset: https://github.com/ovn-org/ovn/compare/75b3e40a55a5...5309099ec38c

View the full build log and details: https://travis-ci.org/ovn-org/ovn/builds/618200393?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the ovn-org/ovn repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=24187664&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20191128/ea1e844f/attachment.html>


More information about the build mailing list