[ovs-build] Failed: orgcandman/ovs#165 (branch-2.10 - 1de3f24)

Travis CI builds at travis-ci.org
Fri Oct 4 20:48:44 UTC 2019


Build Update for orgcandman/ovs
-------------------------------------

Build: #165
Status: Failed

Duration: 32 mins and 20 secs
Commit: 1de3f24 (branch-2.10)
Author: Nitin Katiyar
Message: lacp: Avoid packet drop on LACP bond after link up

Problem:
========
The OVS state machine that enables and disables bond slaves runs in
the OVS main thread. The OVS code that processes received LACP packets
runs in a different thread. Until now, when the latter processes a LACP
PDU that should enable a slave, the slave was only enabled when the
main thread was able to run the state machine. In some cases this led
to delays of up to 350ms when the main thread was busy or not scheduled,
which led to corresponding delays in which packets were dropped due to
the bond-admissibility check.

Fix:
====
When a LACP PDU is received, evaluate whether LACP slave can be enabled
(slave_may_enable()) and set LACP slave's may_enable from the datapath
thread itself. When may_enable = TRUE, it means L1 state is UP and
LACP-SYNC is done and it is waiting for the main thread to enable the
slave. Relax the check in bond_check_admissibility() to check for both
"enable" and "may_enable" of the LACP slave. This would avoid dropping
of packets until the main thread enables the slave from bundle_run().

Signed-off-by: Manohar Krishnappa Chidambaraswamy <manukc at gmail.com>
Co-authored-by: Manohar Krishnappa Chidambaraswamy <manukc at gmail.com>
Signed-off-by: Nitin Katiyar <nitin.katiyar at ericsson.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

View the changeset: https://github.com/orgcandman/ovs/compare/8daf95ba359c^...1de3f24735ba

View the full build log and details: https://travis-ci.org/orgcandman/ovs/builds/593717885?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the orgcandman/ovs repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=5310479&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20191004/ba70a588/attachment-0001.html>


More information about the build mailing list