[ovs-build] Passed: horms2/ovs#325 (greg/backport - a79015e)

Travis CI builds at travis-ci.org
Fri Oct 18 10:43:51 UTC 2019


Build Update for horms2/ovs
-------------------------------------

Build: #325
Status: Passed

Duration: 5 mins and 38 secs
Commit: a79015e (greg/backport)
Author: Arnd Bergmann
Message: datapath: hide clang frame-overflow warnings

Upstream commit:
    commit 260637903f47f20c5918bb5c1eea52b2a28ea863
    Author: Arnd Bergmann <arnd at arndb.de>
    Date:   Mon Jul 22 17:00:01 2019 +0200

    ovs: datapath: hide clang frame-overflow warnings

    Some functions in the datapath code are factored out so that each
    one has a stack frame smaller than 1024 bytes with gcc. However,
    when compiling with clang, the functions are inlined more aggressively
    and combined again so we get

    net/openvswitch/datapath.c:1124:12: error: stack frame size of 1528 bytes in function 'ovs_flow_cmd_set' [-Werror,-Wframe-larger-than=]

    Marking both get_flow_actions() and ovs_nla_init_match_and_action()
    as 'noinline_for_stack' gives us the same behavior that we see with
    gcc, and no warning. Note that this does not mean we actually use
    less stack, as the functions call each other, and we still get
    three copies of the large 'struct sw_flow_key' type on the stack.

    The comment tells us that this was previously considered safe,
    presumably since the netlink parsing functions are called with
    a known backchain that does not also use a lot of stack space.

    Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.")
    Signed-off-by: Arnd Bergmann <arnd at arndb.de>
    Signed-off-by: David S. Miller <davem at davemloft.net>

Cc: Arnd Bergmann <arnd at arndb.de>
Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>
Signed-off-by: Simon Horman <simon.horman at netronome.com>

View the changeset: https://github.com/horms2/ovs/commit/a79015e14224

View the full build log and details: https://travis-ci.org/horms2/ovs/builds/599535835?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the horms2/ovs repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=20314049&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20191018/706d4025/attachment.html>


More information about the build mailing list