[ovs-build] Broken: openvswitch/ovs#8759 (branch-2.11 - c5edeb3)

Travis CI builds at travis-ci.org
Mon Oct 28 21:38:38 UTC 2019


Build Update for openvswitch/ovs
-------------------------------------

Build: #8759
Status: Broken

Duration: 1 hr, 26 mins, and 3 secs
Commit: c5edeb3 (branch-2.11)
Author: Ilya Maximets
Message: dpif-netdev: Fix time delta overflow in case of race for meter lock.

There is a race window between getting the time and getting the meter
lock.  This could lead to situation where the thread with larger
current time (this thread called time_{um}sec() later than others)
will acquire meter lock first and update meter->used to the large
value.  Next threads will try to calculate time delta by subtracting
the large meter->used from their lower time getting the negative value
which will be converted to a big unsigned delta.

Fix that by assuming that all these threads received packets in the
same time in this case, i.e. dropping negative delta to 0.

CC: Jarno Rajahalme <jarno at ovn.org>
Fixes: 4b27db644a8c ("dpif-netdev: Simple DROP meter implementation.")
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-September/363126.html
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: William Tu <u9012063 at gmail.com>

View the changeset: https://github.com/openvswitch/ovs/compare/364f83bb0d55...c5edeb3b3190

View the full build log and details: https://travis-ci.org/openvswitch/ovs/builds/604011825?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the openvswitch/ovs repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=2143550&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20191028/cdaa1a4e/attachment-0001.html>


More information about the build mailing list