[ovs-build] Errored: dceara/ovs#45 (ofproto-trace-nat-v2 - 4e7c9a7)

[Travis CI]

Build Update for dceara/ovs
-------------------------------------

Build: #45
Status: Errored

Duration: 19 secs
Commit: 4e7c9a7 (ofproto-trace-nat-v2)
Author: Dumitru Ceara
Message: ofproto-dpif-trace: Improve NAT tracing.

When ofproto/trace detects a recirc action it resumes execution at the
specified next table. However, if the ct action performs SNAT/DNAT,
e.g., ct(commit,nat(src=1.1.1.1:4000),table=42), the src/dst IPs and
ports in the oftrace_recirc_node->flow field are not updated. This leads
to misleading outputs from ofproto/trace as real packets would actually
first get NATed and might match different flows when recirculated.

Assume the first IP/port from the NAT src/dst action will be used by
conntrack for the translation and update the oftrace_recirc_node->flow
accordingly. This is not entirely correct as conntrack might choose a
different IP/port but the result is more realistic than before.

This fix covers new connections. However, for reply traffic that executes
actions of the form ct(nat, table=42) we still don't update the flow as
we don't have any information about conntrack state when tracing.

Also move the oftrace_recirc_node processing out of ofproto_trace()
and to its own function, ofproto_trace_recirc_node() for better
readability/

Signed-off-by: Dumitru Ceara <dceara at redhat.com>

---
v2:
- Address Ben's comments:
  - Move trace node flow code replacement to ofproto_trace_*().
  - Add outputs describing the NAT actions.
- Move recirc node processing to its own function for better
  readability (ofproto_trace_recirc_node).

View the changeset: https://github.com/dceara/ovs/compare/61a5264d60d0^...4e7c9a75a376

View the full build log and details: https://travis-ci.org/dceara/ovs/builds/635167376?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the dceara/ovs repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=25057358&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20200110/283f758c/attachment.html>