[ovs-build] Fixed: booxter/ovn#5 (dhcp-broadcast - 047c9ed)

Travis CI builds at travis-ci.org
Fri Mar 6 01:40:04 UTC 2020


Build Update for booxter/ovn
-------------------------------------

Build: #5
Status: Fixed

Duration: 16 mins and 28 secs
Commit: 047c9ed (dhcp-broadcast)
Author: Ihar Hrachyshka
Message: Broadcast DHCPREPLY when BROADCAST flag is set

As per RFC2131, section 4.1:
   A server or relay agent sending or relaying a DHCP message directly
   to a DHCP client (i.e., not to a relay agent specified in the
   'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags'
   field.  If this bit is set to 1, the DHCP message SHOULD be sent as
   an IP broadcast using an IP broadcast address (preferably 0xffffffff)
   as the IP destination address and the link-layer broadcast address as
   the link-layer destination address.

This patch changes destination IP address to 255.255.255.255 when client
set BROADCAST flag in their DHCPREQUEST. Note: the offered IP address is
still part of the DHCP payload.

While the new DHCP response is sent as a broadcast IP frame, it's
handled locally, as any other DHCP reply by the native responder.
Meaning, the reply is sent to the client port that initiated the DHCP
session only.

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1801006

Signed-off-by: Ihar Hrachyshka <ihrachys at redhat.com>

---

Version 5:
  * Applied htons to a constant to help compilers optimize
    is_dhcp_flags_broadcast.
  * Clarified in commit message that the IP frame is still sent to
    client only.
Version 4:
  * Introduced DHCP_BROADCAST_FLAG macro.
Version 3:
  * Converted DHCP_FLAGS_BROADCAST into a static function.
  * Used full sentences in comments (added missing dot).
  * Negated if-condition to handle least common case in else branch.
  * Fixed build with --enable-sparse --enable-Werror.
  * Updated ovn-northd documentation to reflect new flow actions.
Version 2:
  * Fixed line length warning reported by checkpatch.

View the changeset: https://github.com/booxter/ovn/compare/9bd7c5248ea9...047c9ed6fa60

View the full build log and details: https://travis-ci.org/booxter/ovn/builds/658960095?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the booxter/ovn repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=27978448&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20200306/eb187053/attachment-0001.html>


More information about the build mailing list