[ovs-build] Passed: ovsrobot/ovs#2353 (series_163475 - fd08607)

Travis CI builds at travis-ci.org
Tue Mar 10 18:00:26 UTC 2020


Build Update for ovsrobot/ovs
-------------------------------------

Build: #2353
Status: Passed

Duration: 1 hr, 14 mins, and 51 secs
Commit: fd08607 (series_163475)
Author: Dumitru Ceara
Message: ovsdb-idl.c: Clear conditions when clearing IDL.

If the ovsdb-server reply to "monitor_cond_since" requests has
"found" == false then ovsdb_idl_db_parse_monitor_reply() calls
ovsdb_idl_db_clear() which iterates through all tables and
unconditionally sets table->cond_changed to false.

However, if the client had already set a new condition for some of the
tables, this new condition request will never be sent to ovsdb-server
until the condition is reset to a different value. This is due to the
check in ovsdb_idl_db_set_condition().

In order to fix this we now also call ovsdb_idl_condition_clear() for
each table condition in ovsdb_idl_db_clear(). This ensures that
resetting the condition to the same value as before the
"monitor_cond_since" reply will trigger a new request.

One way to replicate the issue is described in the bugzilla reporting
the bug, when ovn-controller is configured to use "ovn-monitor-all":
https://bugzilla.redhat.com/show_bug.cgi?id=1808125#c6

Reported-by: Dan Williams <dcbw at redhat.com>
Reported-at: https://bugzilla.redhat.com/1808125
CC: Andy Zhou <azhou at ovn.org>
Fixes: 5351980b047f ("ovsdb-idl: Avoid sending redundant conditional monitoring updates")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: 0-day Robot <robot at bytheb.org>

View the changeset: https://github.com/ovsrobot/ovs/commit/fd086072f608

View the full build log and details: https://travis-ci.org/ovsrobot/ovs/builds/660715332?utm_medium=notification&utm_source=email

--

You can unsubscribe from build emails from the ovsrobot/ovs repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=22285853&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20200310/a457e087/attachment.html>


More information about the build mailing list