[ovs-build] Passed: ovsrobot/ovn#1067 (series_205715 - e6b2aeb)

Travis CI builds at travis-ci.com
Fri Oct 2 21:56:08 UTC 2020


Build Update for ovsrobot/ovn
-------------------------------------

Build: #1067
Status: Passed

Duration: 22 mins and 40 secs
Commit: e6b2aeb (series_205715)
Author: Han Zhou
Message: ofctrl.c: Avoid repeatedly linking an installed flow and a desired flow.

In update_installed_flows_by_compare() there are two loops. The first
loop iterates the installed flows and find its peer in desired flows to
1. uninstall flows that are not needed anymore
2. update flows if needed
At the same time, it links the desired flow found for the installed flow
which also set the desired flow as the current active installed flow.

The second loop iterates the desired flows and find its peer in installed
flows to install missing flows. At the same time it will detect if there
are conflict desired flows matching same installed flow then just link
them.

However, currently in the second loop, it blindly link the desired flows
to the installed flows, without checking if it is already linked. Lucky
enough, this won't cause any real problem so far, because when there are
conflict flows, the one found in the first loop will also be the one
traversed first in the second loop. After the first loop, each installed
flow will be linked to one and only one desired flow, and in the second
loop the same ones will be readded to the list - readding the only element
in the list becomes a no-op.

However, this is still a bug and this patch fixes it to avoid potential
problems and confusion in the code.

Signed-off-by: Han Zhou <hzhou at ovn.org>
Signed-off-by: 0-day Robot <robot at bytheb.org>

View the changeset: https://github.com/ovsrobot/ovn/commit/e6b2aeba13d2

View the full build log and details: https://travis-ci.com/github/ovsrobot/ovn/builds/187912552?utm_medium=notification&utm_source=email


--

You can unsubscribe from build emails from the ovsrobot/ovn repository going to https://travis-ci.com/account/preferences/unsubscribe?repository=9136199&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.com/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-build/attachments/20201002/4042a4a0/attachment.html>


More information about the build mailing list