[ovs-dev] [PATCH] ovs-vsctl: Set timeout to a default value of five seconds
Justin Pettit
jpettit at nicira.com
Mon Dec 14 22:52:00 UTC 2009
On Dec 14, 2009, at 2:35 PM, Ben Pfaff wrote:
> Justin Pettit <jpettit at nicira.com> writes:
>
>> In general, we don't want ovs-vsctl to wait forever to connect to the
>> database, as ovs-vsctl is used extensively in init scripts and the
>> system will not boot. Use a default value of five seconds as a
>> stop-gap. Eventually, we'll switch to a model of connection attempts,
>> since using time-based approach is kind of a hack.
>
> The code looks fine.
>
> I'd like the documentation to clarify that the timeout is 5
> seconds in the absence of any -t or --timeout option, as opposed
> to a default if -t or --timeout is given without specifying an
> argument. (The latter won't work, but it might not be clear to
> someone who doesn't try it and just assumes from the manpage.)
Okay, I took another stab at it and pushed.
--Justin
More information about the dev
mailing list