[ovs-dev] [PATCH] ovs-ofctl: Fix use-after-free error in del-flows command.

Justin Pettit jpettit at nicira.com
Thu Nov 5 07:45:29 UTC 2009


On Nov 4, 2009, at 5:41 PM, Jean Tourrilhes wrote:

> On Wed, Nov 04, 2009 at 01:27:38PM -0800, Ben Pfaff wrote:
>> Justin Pettit <jpettit at nicira.com> writes:
>>
>>> From: Jean Tourrilhes <jt at hpl.hp.com>
>>
>> Looks good.
>
> 	Hi,
>
> 	Sorry to bother you again. Actually, I've just realised that
> it does not look good. It force the user to specify an action when
> deleting a flow, which is not desirable.
> 	I would suggest to revert the patch. It's actually no needed,
> as the buffer is never passed to str_to_flow() in the original code.
> 	I've attached a patch that revert it, but you probably don't
> need it.
> 	Sorry again for the confusion...
>
> 	Jean
> <ovs-0.90.6-hpl-revert-del_flows.diff>

I just went ahead and reverted the change.  Thanks for the quick catch!

--Justin






More information about the dev mailing list