[ovs-dev] [PATCH] bonding: Ignore updelay if there is no active slave.

Ben Pfaff blp at nicira.com
Fri Nov 6 17:10:21 UTC 2009


Jesse Gross <jesse at nicira.com> writes:

> If all slaves on a bond are down but some are waiting for an updelay,
> enable the slave with the shortest amount of delay remaining.  This
> would already occur if all other slaves were disabled at the time the
> delay was to begin but not if a delay was already in progress.  This
> also immediately sends learning packets out in both situations, which
> prevents incoming packets to disabled slaves from being blackholed.

Why does this patch add static data (moving_active_iface in
bond_enable_slave())?  Is it going to work if there is more than
one bond on a bridge, or if there is more than one bond across
all the bridges?

Also, based on the comments in bond_enable_slave(), I think that
this is an optimization.  But I'd rather avoid that optimization,
because it adds more paths that will be harder to test and
because this is not an important fast-path.




More information about the dev mailing list