[ovs-dev] [PATCH] udatapath: Implement ZERO_TCP_FLAGS option.

Ben Pfaff blp at nicira.com
Fri Nov 6 22:32:12 UTC 2009


Jesse Gross <jesse at nicira.com> writes:

> An option to zero the TCP flags when querying flow stats was added
> to the kernel datapath to support NetFlow active timeouts.  This
> adds that same support to the user datapath.

Looks OK, except:

>  static void
> -answer_flow_query(const struct dp_netdev_flow *flow,
> +answer_flow_query(struct dp_netdev_flow *flow, __u32 query_flags,
>                    struct odp_flow *odp_flow)

__u32 is a Linux-kernel type.  In userspace code we should use
uint32_t instead (or just "int" works fine here too).




More information about the dev mailing list