[ovs-dev] [PATCH] ofproto: Correctly credit stats for displaced rules.

Jesse Gross jesse at nicira.com
Thu Nov 12 22:58:04 UTC 2009


When a rule displaces another, we are supposed to credit the stats
for packets that have already been processed to the displaced rule
before we eject it from the datapath.  However, we were instead
crediting the new rule.
---
 secchan/ofproto.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/secchan/ofproto.c b/secchan/ofproto.c
index cfaf0cf..200633e 100644
--- a/secchan/ofproto.c
+++ b/secchan/ofproto.c
@@ -1625,7 +1625,7 @@ rule_install(struct ofproto *p, struct rule *rule, struct rule *displaced_rule)
                          &put)) {
             rule->installed = true;
             if (displaced_rule) {
-                update_stats(p, rule, &put.flow.stats);
+                update_stats(p, displaced_rule, &put.flow.stats);
                 rule_post_uninstall(p, displaced_rule);
             }
         }
-- 
1.6.0.4





More information about the dev mailing list