[ovs-dev] [PATCH 1/2] datapath: Check for proto_data_valid member instead of kernel version.

Ben Pfaff blp at nicira.com
Thu Nov 19 18:28:47 UTC 2009


Ian Campbell <Ian.Campbell at citrix.com> writes:

> On Wed, 2009-11-18 at 23:27 +0000, Ben Pfaff wrote:
>> Commit 5ef800a69 "datapath: Copy Xen's checksumming fields when doing
>> skb_copy" should copy proto_data_valid between sk_buffs when that field
>> is present.  However the check for CONFIG_XEN plus kernel version 2.6.18
>> isn't sufficient, because SLES 11 kernels are version 2.6.27 but do have
>> this field.
>
> Looks good to me. I think you might also want:
>
> Subject: Use HAVE_PROTO_DATA_VALID when defining vswitch_skb_checksum_setup

You're right.  Thank you very much, I pushed this too.




More information about the dev mailing list