[ovs-dev] [PATCH] ovs-controller : add wildcard and normal support

[Justin Pettit]

Thanks, guys.  Just a couple of comments:

On Nov 19, 2009, at 10:18 AM, Ben Pfaff wrote:

> Jean, that's nice.  I touched it up a little and here it is again
> with those changes for you (and anyone) to look at.  Let me know
> if it looks like I misinterpreted anything.
> 
> From 8e4ecfe677cce7c0009d2a7199d9890d087ae0b1 Mon Sep 17 00:00:00 2001
> From: Jean Tourrilhes <jt at hpl.hp.com>
> Date: Thu, 19 Nov 2009 10:16:46 -0800
> Subject: [PATCH] ovs-controller: Add --wildcard and --normal features.
> 
> 
> +.IP "\fB-N\fR, \fB--normal\fR"
> +By default, \fBovs\-controller\fR directs packets to a particular port
> +or floods them.  This option causes it to direct non-flooded packets
> +to the OpenFlow \fBOFPP_NORMAL\fR port.  This allows the switch itself
> +to make decisions about packet destinations.  Switch implementations
> +of \fBOFPP_NORMAL\fR vary widely, so this option may not work well
> +with every switch.

I understand that not all OpenFlow switches implement the OFPP_NORMAL port, but all versions of Open vSwitch do.  Since this is shipped with Open vSwitch and really only used for debugging, I think this may give the wrong impression.  How about something like the following?

    Support for \fBOFPP_NORMAL\fR is optional in OpenFlow, so this 
    option may not well with some non-Open vSwitch switches.

> +/* -N, --normal: Use "NORMAL" action instead of explicit port? */
> +static bool action_normal = false;
> +
> +/* -w, --wildcard: Set up exact match or wildcard flow entries? */
> +static bool exact_flows = false;

Shouldn't this default to true?

--Justin