[ovs-dev] [PATCH] ovs-controller : add wildcard and normal support

[Ben Pfaff]

Justin Pettit <jpettit at nicira.com> writes:

> I understand that not all OpenFlow switches implement the
> OFPP_NORMAL port, but all versions of Open vSwitch do.  Since
> this is shipped with Open vSwitch and really only used for
> debugging, I think this may give the wrong impression.  How
> about something like the following?
>
>     Support for \fBOFPP_NORMAL\fR is optional in OpenFlow, so this 
>     option may not well with some non-Open vSwitch switches.

That's much better, thanks.

>> +/* -N, --normal: Use "NORMAL" action instead of explicit port? */
>> +static bool action_normal = false;
>> +
>> +/* -w, --wildcard: Set up exact match or wildcard flow entries? */
>> +static bool exact_flows = false;
>
> Shouldn't this default to true?

Yes, thanks.

I pushed this out to master, with those changes.