[ovs-dev] [sFlow 1/7] acinclude.m4: Fix inconsistency.
Ben Pfaff
blp at nicira.com
Mon Nov 23 20:22:37 UTC 2009
Thanks, I'll push this soon.
Justin Pettit <jpettit at nicira.com> writes:
> Seems reasonable.
>
> --Justin
>
>
> On Nov 19, 2009, at 1:48 PM, Ben Pfaff wrote:
>
>> Both ; and : are valid shell commands here, but one branch of the "if"
>> uses one and the other branch uses the other. Use the same one, for
>> consistency's sake.
>> ---
>> acinclude.m4 | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/acinclude.m4 b/acinclude.m4
>> index e938e6f..767414e 100644
>> --- a/acinclude.m4
>> +++ b/acinclude.m4
>> @@ -222,7 +222,7 @@ AC_DEFUN([OVS_CHECK_CC_OPTION],
>> AC_COMPILE_IFELSE([AC_LANG_PROGRAM(,)], [ovs_cv_name[]=yes], [ovs_cv_name[]=no])
>> CFLAGS="$ovs_save_CFLAGS"])
>> if test $ovs_cv_name = yes; then
>> - m4_if([$2], [], [;], [$2])
>> + m4_if([$2], [], [:], [$2])
>> else
>> m4_if([$3], [], [:], [$3])
>> fi
>> --
>> 1.6.3.3
>>
>>
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev_openvswitch.org
More information about the dev
mailing list