[ovs-dev] [PATCH] netdev-linux: Return correct error codes on receive.
Jesse Gross
jesse at nicira.com
Fri Oct 2 17:39:34 UTC 2009
netdev_linux_receive was returning positive error codes while the
interface specifies that it should be returning negative errors.
This difference causes a huge increase in (non-existant) packet
processing with the userspace datapath.
---
lib/netdev-linux.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 50a0d2d..c71bdd4 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -370,7 +370,7 @@ netdev_linux_recv(struct netdev *netdev_, void *data, size_t size)
if (netdev->tap_fd < 0) {
/* Device was opened with NETDEV_ETH_TYPE_NONE. */
- return EAGAIN;
+ return -EAGAIN;
}
for (;;) {
@@ -382,7 +382,7 @@ netdev_linux_recv(struct netdev *netdev_, void *data, size_t size)
VLOG_WARN_RL(&rl, "error receiving Ethernet packet on %s: %s",
strerror(errno), netdev_get_name(netdev_));
}
- return errno;
+ return -errno;
}
}
}
--
1.6.0.4
More information about the dev
mailing list