[ovs-dev] [PATCH 2/2] vswitch: Allow user to set Ethernet address of any internal interface.

Justin Pettit jpettit at nicira.com
Fri Oct 2 20:22:09 UTC 2009


On Oct 2, 2009, at 10:59 AM, Ben Pfaff wrote:

> +        eth_addr_from_uint64(mac, ea);
> +        if (eth_addr_is_multicast(ea)) {
> +            VLOG_ERR("interface %s: not setting MAC to multicast  
> address",
> +                     iface->name);

I think this message may be clearer as "cannot set MAC to a multicast  
address."

> /* Port mirroring. */
>
> diff --git a/vswitchd/ovs-vswitchd.conf.5.in b/vswitchd/ovs- 
> vswitchd.conf.5.in
> index e1c12f1..e7c11ff 100644
> --- a/vswitchd/ovs-vswitchd.conf.5.in
> +++ b/vswitchd/ovs-vswitchd.conf.5.in
> @@ -62,7 +62,11 @@ etc. using the usual system tools (e.g.  
> \fBifconfig\fR, \fBip\fR).  To
> designate network device \fInetdev\fR as an internal port, add
> \fBiface.\fInetdev\fB.internal=true\fR to the configuration file.
> \fBovs\-vswitchd\fR will honor this configuration setting by  
> automatically
> -creating the named internal port.
> +creating the named internal port.  Such an internal port by default
> +has a random Ethernet address, but you may configure a specific
> +address by setting \fBiface.\fInetdev\fB.mac\fR to a MAC address in
> +the format \fIxx\fB:\fIxx\fB:\fIxx\fB:\fIxx\fB:\fIxx\fB:\fIxx\fR,
> +where each \fIx\fR is a hex digit.

Do you think we should give some sort of description on the difference  
between an interface and a port?  I think it was mildly confusing  
before, but now there are three different ways to modify the MAC  
address on a "port", and the distinction between and interface and  
port is somewhat subtle.

--Justin







More information about the dev mailing list