[ovs-dev] [PATCH 2/2] dpif-linux: Fix reversed arguments in error message

Justin Pettit jpettit at nicira.com
Fri Oct 2 22:32:05 UTC 2009


When the Open vSwitch devices are already created but point to the wrong
major device, a warning is printed and they are cleaned up.  The correct
and incorrect device numbers are reversed in this warning.
---
 lib/dpif-linux.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 2d9c47e..21c143f 100644
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -576,8 +576,8 @@ make_openvswitch_device(int minor, char **fnp)
         } else if (s.st_rdev != dev) {
             VLOG_WARN_RL(&error_rl,
                          "%s is device %u:%u instead of %u:%u, fixing",
-                         fn, major(s.st_rdev), minor(s.st_rdev),
-                         major(dev), minor(dev));
+                         fn, major(dev), minor(dev),
+                         major(s.st_rdev), minor(s.st_rdev));
         } else {
             goto success;
         }
-- 
1.5.5





More information about the dev mailing list