[ovs-dev] [PATCH 1/2] dpif-linux: Fail earlier if OVS kernel module isn't loaded

Ben Pfaff blp at nicira.com
Fri Oct 2 22:42:35 UTC 2009


Justin Pettit <jpettit at nicira.com> writes:

> When the kernel module isn't loaded, the bridge tries to open all the
> possible minor devices, regardless.  This change first checks that there
> is a major device number for Open vSwitch and only then tries to open the
> minor devices.

Looks OK to me.  I think that it adds logging in more places than
it needs to, though: just logging the failure to get the major
number at the point where we fail to get it should be enough,
instead of also logging it in the callers.

Thanks.




More information about the dev mailing list