[ovs-dev] [PATCH 2/2] dpif-linux: Fix reversed arguments in error message

Ben Pfaff blp at nicira.com
Fri Oct 2 22:45:20 UTC 2009


Justin Pettit <jpettit at nicira.com> writes:

> When the Open vSwitch devices are already created but point to the wrong
> major device, a warning is printed and they are cleaned up.  The correct
> and incorrect device numbers are reversed in this warning.

I think that it is grammatically debatable whether the current
ordering is incorrect.  It looks correct to me, for example.  So
that means that it would look incorrect to me if you reversed it.

What if you just changed "instead of" to "but should be" in the
warning?




More information about the dev mailing list