[ovs-dev] [PATCH 1/2] dpif-linux: Fail earlier if OVS kernel module isn't loaded

Justin Pettit jpettit at nicira.com
Fri Oct 2 23:55:56 UTC 2009

On Oct 2, 2009, at 3:42 PM, Ben Pfaff wrote:

> Justin Pettit <jpettit at nicira.com> writes:
>> When the kernel module isn't loaded, the bridge tries to open all the
>> possible minor devices, regardless.  This change first checks that  
>> there
>> is a major device number for Open vSwitch and only then tries to  
>> open the
>> minor devices.
> Looks OK to me.  I think that it adds logging in more places than
> it needs to, though: just logging the failure to get the major
> number at the point where we fail to get it should be enough,
> instead of also logging it in the callers.

Yeah, it felt sort of verbose to me, too.  I went ahead and removed  
the extra logging and pushed.


More information about the dev mailing list