[ovs-dev] [PATCH] netflow: Increase maximum number of NetFlow records to 30.

Ben Pfaff blp at nicira.com
Mon Oct 5 20:38:03 UTC 2009


Jesse Gross <jesse at nicira.com> writes:

> NetFlow v5 allows up to 30 records per packet but we were incorrectly
> limiting to 29.  This corrects that and also uses the count of the
> number of records in the header rather than the packet size since
> it is easier to reason about.

Looks OK.

I think I was concerned about overflowing a frame here but 24 +
30 * 48 == 1464 still gives adequate overhead in a 1500-byte
frame.  If you wanted to be really explicit you could add a
comment with that arithmetic.




More information about the dev mailing list