[ovs-dev] [PATCH] netflow: Populate NetFlow output interface field.
jpettit at nicira.com
Mon Oct 26 23:02:14 UTC 2009
On Oct 23, 2009, at 4:00 PM, Jesse Gross wrote:
> Previously NetFlow expiration messages always contained 0 as the
> output interface index. This changes that to report the OpenFlow
> interface instead.
Thanks for adding this. It looks reasonable to me. Just a couple of
> case OFPP_CONTROLLER:
> add_controller_action(ctx->out, oao);
> + ctx->nf_output_iface = ODPP_LOCAL;
Shouldn't this line be below for OFPP_LOCAL?
I spoke with Pete about what should be done with packets that are only
sent to the controller, and he suggested that we don't generate
NetFlow records for them.
> case OFPP_LOCAL:
> add_output_action(ctx, ODPP_LOCAL);
Also, I think it would be good to document the special meaning of
these ports. Perhaps in the ovs-vswitch.conf man page. While you're
in there, it might be nice to describe that when the "add-id-to-iface"
flag is enabled that the maximum number of supported ports is going to
More information about the dev