[ovs-dev] [PATCH] netflow: Populate NetFlow output interface field.

Jesse Gross jesse at nicira.com
Tue Oct 27 20:52:50 UTC 2009

Justin Pettit wrote:
>>     case OFPP_CONTROLLER:
>>         add_controller_action(ctx->out, oao);
>> +        ctx->nf_output_iface = ODPP_LOCAL;
> Shouldn't this line be below for OFPP_LOCAL?
> I spoke with Pete about what should be done with packets that are only 
> sent to the controller, and he suggested that we don't generate 
> NetFlow records for them.

This was correct give what I was intending to do (report controller 
traffic as local) since add_output_action already sets the output 
interface.  However, now I'm not generating NetFlow records for 
controller traffic.

>>         break;
>>     case OFPP_LOCAL:
>>         add_output_action(ctx, ODPP_LOCAL);
> Also, I think it would be good to document the special meaning of 
> these ports.  Perhaps in the ovs-vswitch.conf man page.  While you're 
> in there, it might be nice to describe that when the "add-id-to-iface" 
> flag is enabled that the maximum number of supported ports is going to 
> around 509.

Good idea, I updated the man page.

I went ahead and pushed it with these modifications.  There may be 
additional NetFlow modifications that we want but those are independent 
of this.

More information about the dev mailing list