Justin Pettit <jpettit at nicira.com> writes: > + local internal=$(${vif_on_internal_bridge} ${DOMID} ${DEVID}) > + if [ $internal = "true" ]; then Please quote $internal as "$internal", in case the vif_on_internal_bridge script encounters an error. Otherwise it looks fine to me, as long as it works.